Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Reduce allocations in ToBits for Plaintext #2499

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

ljedrz
Copy link
Collaborator

@ljedrz ljedrz commented Jun 19, 2024

A revival of #2458, as requested by @vicsn.

@ljedrz ljedrz marked this pull request as ready for review June 25, 2024 09:53
@ljedrz ljedrz force-pushed the perf/plaintext_bits_allocs branch from 2ce7dc7 to bea4d97 Compare June 25, 2024 09:53
raychu86
raychu86 previously approved these changes Jul 3, 2024
Copy link
Contributor

@raychu86 raychu86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This PR was already approved and merged, prior to revert.

Signed-off-by: ljedrz <ljedrz@users.noreply.github.com>
@ljedrz ljedrz force-pushed the perf/plaintext_bits_allocs branch from bea4d97 to e47930c Compare July 5, 2024 10:06
@raychu86 raychu86 changed the title Reduce allocations in ToBits for Plaintext [Perf] Reduce allocations in ToBits for Plaintext Jul 8, 2024
@ljedrz
Copy link
Collaborator Author

ljedrz commented Jul 9, 2024

CI run link

Copy link
Contributor

@raychu86 raychu86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zosorock zosorock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm as well

@zosorock zosorock merged commit 9645d8b into AleoNet:staging Oct 16, 2024
76 of 83 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants