Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Use type_name instead of literals for LiteralType::parse #2500

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

ljedrz
Copy link
Collaborator

@ljedrz ljedrz commented Jun 19, 2024

A revival of #2459, as requested by @vicsn.

@ljedrz ljedrz force-pushed the refactor/futureproof_literals branch from 200006a to 23a0bad Compare June 25, 2024 09:54
@ljedrz ljedrz marked this pull request as ready for review June 25, 2024 09:54
Copy link
Contributor

@raychu86 raychu86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This change was already approved and merged previously, prior to revert.

@raychu86 raychu86 changed the title Use type_name instead of literals for LiteralType::parse [Chore] Use type_name instead of literals for LiteralType::parse Jul 8, 2024
@ljedrz
Copy link
Collaborator Author

ljedrz commented Jul 9, 2024

CI run link

Signed-off-by: ljedrz <ljedrz@users.noreply.github.com>
@ljedrz ljedrz force-pushed the refactor/futureproof_literals branch from b6e4e09 to 9f25a19 Compare November 14, 2024 17:00
@ljedrz
Copy link
Collaborator Author

ljedrz commented Nov 14, 2024

Rebased for a cleaner merge experience.

@zosorock zosorock added the v1.2.1 Canary release v1.2.1 label Nov 18, 2024
Copy link
Collaborator

@zkxuerb zkxuerb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zosorock zosorock merged commit d432417 into AleoNet:staging Nov 19, 2024
84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v1.2.1 Canary release v1.2.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants