[Perf] Speed up the fetching of the latest block height #2515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ljedrz <ljedrz@users.noreply.github.com>
ljedrz
force-pushed
the
perf/faster_max_height
branch
from
d1fa0c3 to
71c3806
Compare
vicsn
previously approved these changes
Jul 9, 2024
|
Can you point readers to the logic/evidence that the change does not introduce an off-by-one error? |
ljedrz
commented
Jul 10, 2024
Signed-off-by: ljedrz <ljedrz@users.noreply.github.com>
|
@vicsn done; also, I noticed that originally there actually would have been an issue with a height equal to |
vicsn
previously approved these changes
Jul 10, 2024
Signed-off-by: ljedrz <ljedrz@users.noreply.github.com>
|
I just found 2 more instances of max block height lookup (without using One of them will further improve ledger loading time. |
vicsn
approved these changes
Jul 10, 2024
zosorock
requested review from
evanmarshall,
zkxuerb,
zklimaleo,
a team and
fulltimemike
gluax
approved these changes
Oct 19, 2024
vicsn
approved these changes
Oct 21, 2024
zklimaleo
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another heap-profiling find applicable to the loading of the ledger; by counting the number of heights instead of deserializing them, we can avoid a large number of allocations.
The results at height 330598 are as follows: