Add additional Input/Output checks
#2582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicsn
approved these changes
Dec 2, 2024
d0cd
approved these changes
Dec 2, 2024
ljedrz
reviewed
Dec 3, 2024
ljedrz
reviewed
Dec 3, 2024
ljedrz
reviewed
Dec 3, 2024
ljedrz
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR adds additional input/output checks to transaction verification in order to cover all cases. Previously we added length checks in #2511; for completeness, we now add variant type checks as well.
CI is run here.
Test Plan
Tested on local devnets and isonets. Sync tests have also been run to ensure that existing networks are fully compatible.