Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more tests for command install #43

Merged
merged 3 commits into from
Jul 4, 2024
Merged

Conversation

tannguyen04
Copy link
Contributor

@tannguyen04 tannguyen04 commented Jun 26, 2024

Closes #

closes #40

Checklist before requesting a review

  • I have formatted the subject to include ticket number as [#123] Verb in past tense with a period at the end.
  • I have added a link to the issue tracker
  • I have provided information in Changed section about WHY something was done if this was not a normal implementation
  • I have performed a self-review of my code and commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have run new and existing relevant tests locally with my changes, and they passed
  • I have provided screenshots, where applicable

Changed

@tannguyen04 tannguyen04 marked this pull request as ready for review June 26, 2024 23:36
@tannguyen04
Copy link
Contributor Author

tannguyen04 commented Jun 26, 2024

@AlexSkrypnyk

I have done:

  • Added 4 tests as you requested.
  • Create createProjectCommandTestCase class which prepare for both test install and test no install.
  • Create createProjectCommandInstallTest class to test create project commands with install option.
  • Create createProjectCommandNoInstallTest class to test create project commands with no-install option.

I have separate classes because to test create project command with install option we no need to set up autoload as original Added more tests for command install by tannguyen04 · Pull Request #43 · AlexSkrypnyk/customizer

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.25%. Comparing base (7891a28) to head (6ee53d8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
+ Coverage   82.37%   83.25%   +0.88%     
==========================================
  Files           2        2              
  Lines         227      227              
==========================================
+ Hits          187      189       +2     
+ Misses         40       38       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlexSkrypnyk AlexSkrypnyk merged commit 7e3d5e2 into main Jul 4, 2024
8 checks passed
@AlexSkrypnyk AlexSkrypnyk deleted the feature/add-more-tests branch July 4, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more tests for command install
2 participants