Add SIMD hamming distance calculation #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ering bases between two sequences of equal length). Pop count is calculated using SIMD instructions and simple bitwise ops, so it should be pretty quick but I haven't run any benchmarks yet.
…ng their full range.
…rms random slicing all over a ShortSeqVar for extra assurance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hamming distance between two ShortSeqs can now be efficiently calculated with the XOR operator
^. SIMD instructions are used in the calculation so it should be quick, but there's room for improvement esp. for longer sequences. Will revisit the implementation if necessary once I have better benchmarks written.