Improved size reporting for ShortSeqVars and updated usage docs #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…heap allocated storage to sys.getsizeof(). Adding unit test for expected object sizes for min/max lengths.
Adding a command to list CPU details on macOS runners. Hopefully this will illuminate why their runners intermittently fail due to incompatible CPU instruction sets
|
Merging despite failed tests. As I thought, these tests fail when they end up on an agent that's not running on Apple hardware (and I feel like there's a narrative gap with what GitHub says about its runners, but that's beside the point...). In this case agents with an i7 CPU build just fine, but with the Xeon E5-1650 builds fail |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ShortSeqVarobjects now correctly report their size. Previously, heap allocations were not reported when callingsys.getsizeof()The usage section in README.md now showcases some of the recent feature additions.