Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability for controllers auto-mounting #77

Merged
merged 1 commit into from
Nov 12, 2018

Conversation

AlexWayfer
Copy link
Owner

Good bye giant application mount blocks!

But you can disable it with nested: false option for mount,
for example, for conditional umbrella application.

@codecov
Copy link

codecov bot commented Oct 5, 2018

Codecov Report

Merging #77 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #77   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          23     27    +4     
  Lines         773    823   +50     
=====================================
+ Hits          773    823   +50
Impacted Files Coverage Δ
lib/flame/router/controller_finder.rb 100% <100%> (ø)
lib/flame/router/routes_refine.rb 100% <100%> (ø)
lib/flame/errors/controller_not_found_error.rb 100% <100%> (ø)
lib/flame/router.rb 100% <100%> (ø) ⬆️
lib/flame/application.rb 100% <100%> (ø) ⬆️
lib/flame/router/routes_refine/mounting.rb 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 607d6fd...68b8e4a. Read the comment docs.

@AlexWayfer AlexWayfer force-pushed the add_controllers_auto-mounting branch from e56f85c to 38a7d85 Compare October 5, 2018 16:34
Good bye giant application `mount` blocks!

But you can disable it with `nested: false` option for `mount`,
for example, for conditional umbrella application.
@AlexWayfer AlexWayfer force-pushed the add_controllers_auto-mounting branch from 38a7d85 to 68b8e4a Compare October 5, 2018 16:36
@AlexWayfer
Copy link
Owner Author

Looks working.

@AlexWayfer AlexWayfer merged commit 94471c9 into master Nov 12, 2018
@AlexWayfer AlexWayfer mentioned this pull request Mar 9, 2019
@AlexWayfer AlexWayfer deleted the add_controllers_auto-mounting branch March 17, 2019 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant