[OTHER] Yank versions incompatbile with Rust 1.53.0

[legoktm]

Prerequisites

If applicable to the issue, here are a few things you should provide to help me understand the issue:

• Rust version: rustc -V 1.53.0
• lexical version: 0.7.4
• lexical compilation features used:

Description

Please include a clear and concise description of the issue.

Refs #55, rust-lang/rust#85667

It would be nice if the versions that are incompatible with Rust 1.53.0 could be yanked. While yanking doesn't force people to update to the fixed versions, it does help as tools like cargo-audit will now warn that you're using a yanked version and should upgrade.

Additional Context

Add any other context or screenshots about the issue here.

At rust-lang/rust#85667 (comment) @Mark-Simulacrum said "I think yanking is likely not the right step to take at this time." - I wonder if they still think that now that 1.53.0 is stable.

[Mark-Simulacrum]

Yanking isn't generally a good idea for cases like this; it unnecessarily causes churn for users who haven't upgraded to Rust 1.53 and isn't broadly common in the ecosystem today to my knowledge.

[Alexhuszagh]

Every single branch, even unmaintained ones, have been made compatible with Rust 1.53.0, so as long as any users aren't fixed on a specific version, lexical should not have issues.

Merely running cargo update should always update you to a version compatible, and since cargo yank does not prevent existing crates locked to a specific version from using an old, incompatible version, I don't believe yanking is the proper solution.

[Alexhuszagh]

I'm open to re-opening this or merging changes if the Rust core team decides it's a good idea, in the meantime, I've updated every branch (v0.4 to v0.7) to ensure it does not cause compatibility issues with Rust 1.53, so these issues should hopefully be fixed as long as users aren't locked to a version.

[KamilaBorowska]

This would be appreciated for cargo update -Z minimal-versions builds (see rust-lang/cargo#5657). Currently minimal-versions picks those old versions and to avoid that they could be yanked. As far as I can tell, the MSRV was unchanged for those patch releases, so there aren't compatibility concerns.

[Alexhuszagh]

@xfix Sorry for the late reply, if policies around yanking crates has changed, I'm open to doing so, but from I've currently gathered it's unwise to yank unless there's a security vulnerability, syntax error, or an algorithm issue that would lead to major correctness issues.