Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust 1.53.0 #79503

Closed
wants to merge 2 commits into from
Closed

Conversation

branchvincent
Copy link
Member

@branchvincent branchvincent commented Jun 17, 2021

Created with brew bump-formula-pr.

resource blocks may require updates.

@BrewTestBot BrewTestBot added the bump-formula-pr PR was created using `brew bump-formula-pr` label Jun 17, 2021
@carlocab
Copy link
Member

You can update the cargobootstrap resource: https://github.com/rust-lang/rust/blob/53cb7b09b00cbea8754ffb78e7e3cb521cb8af4b/src/stage0.txt#L15-L16

@chenrui333 chenrui333 added the in progress Stale bot should stay away label Jun 17, 2021
@carlocab
Copy link
Member

cargo needed updating too.

@cho-m
Copy link
Member

cho-m commented Jun 20, 2021

Intel failures (mostly due to lexical-core dependency having a type error)

  • grin-wallet - compile error in lexical-core-0.7.4
  • pastel - compile error in lexical-core-0.6.2
  • suricata - compile error in vendored lexical-core
  • zola - compile error in lexical-core-0.7.4
  • maturin - Caused by: Failed to parse Cargo.toml at hello_world/Cargo.toml
  • watchman - /tmp/watchman-20210620-52327-wlyv8o/watchman-2021.06.07.00/watchman_string.h:114:16: error: no member named 'data' in 'watchman_pending_fs'
  • Same failures as rust 1.52.1 #76780: angle-grinder asuka cargo-audit cargo-watch gifski graph-tool ktmpl pc6001vx pdfpc vice wasm-pack

@carlocab
Copy link
Member

watchman sounds related to #79304 and #79383. I think it just doesn't compile with the new version of folly.

@cho-m
Copy link
Member

cho-m commented Jun 20, 2021

For lexical-core issue, corresponding upstreams will need to do new release with a compatible version Alexhuszagh/rust-lexical#65, so probably can ignore

I guess maturin is an issue with Homebrew test. Should fix in a separate PR rather than having to re-run CI here.

Bottled ARM failures are mostly the same. We hit mpv failure again, so seems to be failing more consistently.


Other than maturin, I don't think we can do much for other failures (without modifying lock dependencies), so I think okay to merge.

EDIT: though need to see where maturin is exactly failing (i.e. is it due to Cargo.toml we create or inside maturin code)

@carlocab
Copy link
Member

carlocab commented Jun 20, 2021

==> Testing maturin
/usr/bin/sandbox-exec -f /private/tmp/homebrew20210619-98088-dz0lcg.sb ruby -W1 -- /usr/local/Homebrew/Library/Homebrew/test.rb /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/maturin.rb --verbose --retry
==> cargo new hello_world --bin
     Created binary (application) `hello_world` package
==> /usr/local/Cellar/maturin/0.10.6/bin/maturin build -m hello_world/Cargo.toml -b bin -o dist
💥 maturin failed
  Caused by: Failed to parse Cargo.toml at hello_world/Cargo.toml
  Caused by: missing field `authors` for key `package` at line 8 column 1

cargo probably changed the format of the Cargo.toml that it generates, and this broke maturin.

CC @messense, in case you have any ideas about this

@cho-m
Copy link
Member

cho-m commented Jun 20, 2021

I just tried on my local rustup setup and I see authors is not included in Cargo.toml with 1.53.0 (and 1.55.0 nightly).
I'll see if format changed, or if there is a new argument.
EDIT: rust-lang/rust#83227

@messense
Copy link
Contributor

messense commented Jun 21, 2021

cargo removed authors field by default with cargo new: rust-lang/cargo#9282

It should be easily fixable by patching the Cargo.toml with a authors field.

Edit: Opened #79689

Copy link
Member

@cho-m cho-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although lexical-core issue will temporarily break the build of some Rust formulae, I don't think we should block Rust update on those upstream updates.

If necessary, we can try updating dependencies in lock files.

@carlocab
Copy link
Member

Let's merge this. It looks like it's blocking 3 PRs.

@BrewTestBot
Copy link
Member

:shipit: @carlocab has triggered a merge.

@branchvincent branchvincent deleted the bump-rust-1.53.0 branch June 22, 2021 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` in progress Stale bot should stay away
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants