-
Notifications
You must be signed in to change notification settings - Fork 67
Updated analysis: Update CN consensus calls to use ControlFREEC CN as default? #964
Comments
I am not opposed to this change in principle and would welcome a pull request. The evaluation would need to be more systematic (e.g., examine more if not all samples) and should be captured in this repository in a notebook. |
Agreed- we need to examine. |
I'm getting an error at
It seems like a simple command to cat all the files and seems to work fine when I run it on bash from |
@jashapiro I know you are out this week, but when you are back, would you be able to help with the error above? Thanks! |
I can try to help out. Is there any more detail you can give about exactly how you ran it @kgaonkar6? As far as I am aware, the workflow runs in CI, so there would have to be a pretty specific bug... as a first step, I would check that |
I ran the analysis with this command
I did edit the script I will try a re-run with an empty |
re-running with an empty scratch/copy_consensus worked! 🎉 Thank you, should have tried that before! |
thanks @jashapiro |
Sorry for bringing this up again.. @jashapiro @jashapiro The analysis ran successfully with testing data I had downloaded for another PR I'm working on, but it actually did error out in the same step when I ran it with v18 . I did empty scratch/copy_consensus before running the same command with docker exec above. The log file has the error:
|
Closed with #1066 |
What analysis module should be updated and why?
copy_number_consensus_call
Early on, we had noticed many gains/losses in our oncoprint, but had since created a focal CN file module. Still, while the oncoprints look better, there are still a lot of gains/losses within the TMB plots listed above the oncoprints, and worth mentioning/trying the below.
What changes need to be made? Please provide enough detail for another participant to make the update.
@zhangb1 noticed that for PNOC003 samples, there were still many losses being called for samples which, in some cases, had known amplifications (from clinical sequencing). He has summarized his findings here. His rationale was that ploidy is based on ControlFREEC and thus, using its corresponding CN would probably result in a better estimate of overall CN.
This piece of code:
OpenPBTA-analysis/analyses/copy_number_consensus_call/scripts/bed_to_segfile.R
Lines 119 to 128 in 2c1f5fa
would change to:
What input data should be used? Which data were used in the version being updated?
data being used and to be updated:
consensus_seg_annotated_cn_autosomes.tsv.gz
consensus_seg_annotated_cn_x_and_y.tsv.gz
pbta-cnv-consensus.seg.gz
other data to be updated:
pbta-cnv-consensus-gistic.zip
When do you expect the revised analysis will be completed?
one week, if QC needed
Who will complete the updated analysis?
@kgaonkar6 or @jashapiro or @jharenza ?
Thoughts, @jashapiro and @jaclyn-taroni ?
The text was updated successfully, but these errors were encountered: