This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Part2 Freec as default: Cnv focal files update #988
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/implementation Section
What scientific question is your analysis addressing?
We updated the consensus seg file creation in #987 to use freec CN calls as default. In this PR we will re-run
focal-cn-file-preparation
to identify changes in focal calls because of the update.What was your approach?
Just run run-prepare-cn.sh
What GitHub issue does your pull request address?
related to #964
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Which areas should receive a particularly close look?
🚨 I couldn't complete the plotting in the module.
I haven't run this module before, so I started with having 12GB memory in docker which killed 04-prepare-cn-file.R. I increased that to 15G and re-run the 04,05,06 but it seems rna-expression-validation.R would need more than 15G.
Is this something that was seen before ?
Is there anything that you want to discuss further?
🚨
plots
are not complete for consensus calls because of the mem issue mentioned above.Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?
NO
Results
What types of results are included (e.g., table, figure)?
What is your summary of the results?
Reproducibility Checklist
Documentation Checklist
README
and it is up to date.analyses/README.md
and the entry is up to date.