-
Notifications
You must be signed in to change notification settings - Fork 67
Conversation
@jharenza
Does this sound ok as is ? XY chromosomes don’t have a logic in the current code y to add applications does that sound ok too? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, just want to switch the nomenclature to deep deletion
Co-authored-by: Jo Lynne Rokita <jharenza@gmail.com>
Co-authored-by: Jo Lynne Rokita <jharenza@gmail.com>
Co-authored-by: Jo Lynne Rokita <jharenza@gmail.com>
Thanks for the review @jharenza 🙌. I'll rerun and commit the updated nomenclature output |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comment about removing the amp-->gain change in XY seg file
disregard this - we can make this an after #1048 issue
Co-authored-by: Jaclyn Taroni <jaclyn.n.taroni@gmail.com>
Purpose/implementation Section
What scientific question is your analysis addressing?
Add logic for a "deep loss" call for focal CN output files.
What was your approach?
Changed:
OpenPBTA-analysis/analyses/focal-cn-file-preparation/04-prepare-cn-file.R
Lines 240 to 247 in 6bf301e
To:
Changed:
OpenPBTA-analysis/analyses/focal-cn-file-preparation/04-prepare-cn-file.R
Lines 265 to 267 in 6bf301e
To:
What GitHub issue does your pull request address?
#1099
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Which areas should receive a particularly close look?
Should we convert the "deep loss" added in this PR as "loss" for cytoband annotation OR do we want to add amplification and deep loss annotation to cytobands?
Is there anything that you want to discuss further?
NA
Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?
Yes
Results
What types of results are included (e.g., table, figure)?
table
What is your summary of the results?
"Deep loss" calls were added to focal CN files for autosomes and X+Y calls.
Reproducibility Checklist
Documentation Checklist
README
and it is up to date.analyses/README.md
and the entry is up to date.