-
Notifications
You must be signed in to change notification settings - Fork 67
Rerun changes added #1412
Rerun changes added #1412
Conversation
Posting here the md5sums of the files that went to the v22 folder on S3 from this analysis:
Files which changed from v21:
|
Just noting that when I went about resolving conflicts, I didn't pay too much attention to |
@runjin326 - this is ready to be rerun now that #1421 is in and I've resolved conflicts, thanks! |
Just to confirm, for the re-run, I just merge all the changes in master to my local brand, re-run, upload to s3 and add additional changes to this PR right? |
Yes, but to be specific: I've already merged the changes from |
66fa988
to
00d1833
Compare
@jaclyn-taroni - quick question, for the re-run, do we download data from v22 folder or v21 folder? If from v22, then we are missing |
@jaclyn-taroni and @jharenza - I have now reran the module. Changes are pushed to this PR and all the results are in the s3 bucket. Let me know whether there is anything else you need. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻 LGTM, thanks!
Purpose/implementation Section
What scientific question is your analysis addressing?
Ran generate analysis for data release bash script and these are the changes after the re-run.
What was your approach?
Started an EC2 instance with 1T storage and 256G memory, pull the scripts, run the generate files script, and then push the generated files to S3 bucket.
*Note: I am not so sure about the memory requirement to run everything but the overall storage is ~60G so next time an instance with 100G should be enough.
What GitHub issue does your pull request address?
NA
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Which areas should receive a particularly close look?
NA
Is there anything that you want to discuss further?
No
Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?
Yes
Results
What types of results are included (e.g., table, figure)?
Only gistic results were changed (expected) - and everything else remained the same.
What is your summary of the results?
NA
Reproducibility Checklist
Documentation Checklist
README
and it is up to date.analyses/README.md
and the entry is up to date.