This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 67
Update Documentation to Reflect SNV refactoring #304
Merged
jaclyn-taroni
merged 16 commits into
AlexsLemonade:master
from
cansavvy:update-snv-README
Dec 3, 2019
Merged
Update Documentation to Reflect SNV refactoring #304
jaclyn-taroni
merged 16 commits into
AlexsLemonade:master
from
cansavvy:update-snv-README
Dec 3, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cansavvy
changed the title
Update snv readme
Update Documentation to Reflect SNV refactoring
Dec 2, 2019
jashapiro
reviewed
Dec 2, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good! There are few places where I think more detail would be good, and a bit of repetitiveness that could be cleaned up, I think.
2 tasks
jashapiro
reviewed
Dec 3, 2019
jashapiro
reviewed
Dec 3, 2019
Co-Authored-By: jashapiro <jashapiro@gmail.com>
jashapiro
approved these changes
Dec 3, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/implementation Section
Main changes
What GitHub issue does your pull request address?
#296
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Which areas should receive a particularly close look?
Results
No new results just updating the documentation
Reproducibility Checklist
These items were taken care of previously.