Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Update ATRT molecular subtyping module to use GSVA scores #388

Merged
merged 9 commits into from
Jan 2, 2020

Conversation

jaclyn-taroni
Copy link
Member

Purpose/implementation Section

With #386, we have updated single-sample gene set enrichment scores. Specifically, we have GSVA scores that follow a Gaussian distribution. Here I am updating the molecular-subtyping-ATRT module to use these new scores.

I have made the following changes:

  • Updated the subsetting files (00-subset-files-for-ATRT.R) and main data wrangling (01-ATRT-molecular-subtyping-data-prep.Rmd) steps of this module to use the GSVA scores
  • Updated the module documentation in both molecular-subtying-ATRT README and the analyses README
  • Updated analyses/ssgsea-hallmark/README.md to

What GitHub issue does your pull request address?

Related to #244

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Is there anything else that needs to be updated that I have missed? I have covered everything that I wrote in #368 (comment)

Results

What types of results are included (e.g., table, figure)?

Updates analyses/molecular-subtyping-ATRT/results/ATRT_molecular_subtypes.tsv -- we will need someone with domain expertise to review this table and see what, if any, tweaks need to be made.

Reproducibility Checklist

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.
  • This analysis has been added to continuous integration.
  • This analysis is recorded in the table in analyses/README.md.

@jaclyn-taroni jaclyn-taroni added updated analysis molecular subtyping Related to molecular subtyping of tumors labels Jan 1, 2020
Copy link
Collaborator

@cansavvy cansavvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. LGTM!! Just one minorly minor request that you can take or leave. I notice that most of the data.frames being read and manipulated here are printed out so the reader can see what they look like. Following this pattern, you also print out a preview of the GSVA data? It would help readers follow along with what is happening, but also it seems strange that it is the only dataset that is not being printed out with %>% head(n =15).

@jaclyn-taroni
Copy link
Member Author

Good point! I'll make that change!

@jaclyn-taroni jaclyn-taroni merged commit 9d1db2f into AlexsLemonade:master Jan 2, 2020
@jaclyn-taroni jaclyn-taroni deleted the atrt-gsva branch January 2, 2020 16:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
molecular subtyping Related to molecular subtyping of tumors updated analysis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants