Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Update color scheme for interaction plots #650

Merged

Conversation

jashapiro
Copy link
Member

Purpose/implementation Section

What scientific question is your analysis addressing?

Consistent plots (more aesthetic than scientific)

What was your approach?

Apply the project color scheme in interaction plot scripts.

What GitHub issue does your pull request address?

#510

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

Should be pretty straightforward...

Is there anything that you want to discuss further?

I don't currently use the project histology color scheme, because the script thus far uses integrated_diagnosis in preference to short_histology. Some form of translation table added to the color tables created in #622 could help with this.

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

Yup

Results

What types of results are included (e.g., table, figure)?

Updated figures.

What is your summary of the results?

The figures look pretty good, if I do say so myself.

Reproducibility Checklist

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.
  • This analysis has been added to continuous integration.

Documentation Checklist

  • This analysis module has a README and it is up to date.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to date.
  • The analytical code is documented and contains comments.

Copy link
Member

@jaclyn-taroni jaclyn-taroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants