This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Update color scheme for interaction plots #650
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/implementation Section
What scientific question is your analysis addressing?
Consistent plots (more aesthetic than scientific)
What was your approach?
Apply the project color scheme in interaction plot scripts.
What GitHub issue does your pull request address?
#510
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Which areas should receive a particularly close look?
Should be pretty straightforward...
Is there anything that you want to discuss further?
I don't currently use the project histology color scheme, because the script thus far uses
integrated_diagnosis
in preference toshort_histology
. Some form of translation table added to the color tables created in #622 could help with this.Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?
Yup
Results
What types of results are included (e.g., table, figure)?
Updated figures.
What is your summary of the results?
The figures look pretty good, if I do say so myself.
Reproducibility Checklist
Documentation Checklist
README
and it is up to date.analyses/README.md
and the entry is up to date.