Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

V16 subset files for CircleCI testing #670

Merged
merged 66 commits into from
Apr 4, 2020

Conversation

cansavvy
Copy link
Collaborator

@cansavvy cansavvy commented Apr 2, 2020

Purpose/implementation Section

What scientific question is your analysis addressing?

Setting up the subset files for v16 release so we can test the changes on CircleCI.

What was your approach?

  1. Started AWS instance with 128 GB RAM
  2. Cloned OpenPBTA-analysis
  3. Created a new branch off of yuankunzhu/v16 branch called v16-ci
  4. analyses/create-subset-files/create_subset_files.sh update to v16
  5. Ran bash analyses/create-subset-files/create_subset_files.sh
  6. Committed the biospecimen RDS file to v16-ci branch.
  7. Zipped up the subsetted files in data/testing/release-v16-20200320/ to testing_v16.zip
  8. Downloaded testing_v16.zip

What GitHub issue does your pull request address?

#657

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

  • create_subset_files.sh script noted that there is no release-notes.md file in the v16 data?? Is that forth coming?

  • Are there any steps that I should have taken that are not mentioned here?

  • If all looks as expected, I will upload the subsetted v16 files so we can begin working on breaking changes, but probably would be good to track down the release-notes.md file first.

yuankunzhu and others added 30 commits March 4, 2020 00:22
add folder for notebooks
add gitignore
update output file path handle in get-tcga-capture_kit.py
add boxplot.R
skip the manifest header
add ci for tcga-capture-kit-investigation
Merge branch 'analyses/tcga-capture-kit-investigation' of https://github.com/yuankunzhu/OpenPBTA-analysis into Teja_tmbQC
Co-Authored-By: jashapiro <josh.shapiro@ccdatalab.org>
@jaclyn-taroni jaclyn-taroni mentioned this pull request Apr 2, 2020
4 tasks
@@ -68,9 +68,6 @@ cp $FULL_DIRECTORY/independent-specimens*.tsv $SUBSET_DIRECTORY
# all bed files
cp $FULL_DIRECTORY/*.bed $SUBSET_DIRECTORY

# the release notes
cp $FULL_DIRECTORY/release-notes.md $SUBSET_DIRECTORY
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, this is why I was missing files. Because the script failed at this step before and the other files after it did not get copied. I ran everything again just in case.

Copy link
Member

@jaclyn-taroni jaclyn-taroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jaclyn-taroni jaclyn-taroni merged commit a51b39a into AlexsLemonade:master Apr 4, 2020
@cansavvy cansavvy deleted the v16-ci branch August 13, 2020 11:46
@jaclyn-taroni jaclyn-taroni mentioned this pull request Dec 13, 2020
@kgaonkar6 kgaonkar6 mentioned this pull request Apr 27, 2021
5 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants