-
Notifications
You must be signed in to change notification settings - Fork 67
#837 updated: RNA QC compare stranded vs polya matched sample_ids #930
#837 updated: RNA QC compare stranded vs polya matched sample_ids #930
Conversation
Hmm, there definitely looks like a bias there. However, for the four samples with scores below 0.5, maybe this is within the random variability of the classifier. For 7316-1455, both scores are high, but for 7316-161, the stranded sample would have predicted oncogenic TP53 and the polyA would not. Sorry to keep asking for things - can you create a table of TP53 alterations for each of these samples? (ie - do only 1455 and 161 have alterations)? @gwaygenomics thoughts on this? |
Thanks for the review @jharenza!
It seems for 7316-161 according to the condition of 2 SNV in DNA sample matched with both stranded and poly-A RNA the tp53_status is set to "loss" |
Hmm. I am wondering if we should utilize batch correction once completed via #919 to rerun the classifier for this dataset. I wonder if the scores would be closer together for polyA and stranded in that case. I don't really want to choose one over the other without some additional investigation, but for the most part, while there is a bias, they agree and for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just added the comments to the notebook
Co-authored-by: Jo Lynne Rokita <jharenza@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had one minor comment about showing some information that's currently in a comment that could get out of date, but other than that this looks good to me!
group_by(sample_id,) %>% | ||
# because 7316-85 has multiple stranded I'm taking a mean here | ||
# A tibble: 8 x 2 | ||
# Kids_First_Biospecimen_ID tp53_score_stranded | ||
# <chr> <dbl> | ||
# 1 BS_59ZJWJTF 0.299 | ||
# 2 BS_QYPHA40N 0.0665 | ||
# 3 BS_SB12W1XT 0.229 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion, you are better off showing this output in a chunk rather than including it in a comment that could easily get out of date.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the review! That's a great point, I've now added a chunk to display the output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will merge once CI passes 🚀
Purpose/implementation Section
What scientific question is your analysis addressing?
Is there a difference between stranded and polya samples and if so should we use 1 over other while annotating by TP53 status by sample_id?
What was your approach?
matched tp53_score_stranded and tp53_score_polya by sample_id ( only for sample_ids that have multiple RNA_library). For 7316-85 since there are multiple standed sample I took a mean of all samples.
What GitHub issue does your pull request address?
#837
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Which areas should receive a particularly close look?
This was not part of the original ticket but as part of #837 we are also compiling the tp53 status and @jharenza found multiples which lead to additional investigation and 1 part of QC requested in comment was to compare stranded and polya
Is there anything that you want to discuss further?
Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?
Yes
Results
What types of results are included (e.g., table, figure)?
plots in notebook
What is your summary of the results?
On average it seems the polya samples have lower tp53_scores compared to matched stranded samples.
Reproducibility Checklist
Documentation Checklist
README
and it is up to date.analyses/README.md
and the entry is up to date.