This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 67
Part 1 #819 Combine snv per caller and filter to scavenge hotspots #947
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…A-analysis into recurrence-snv
…A-analysis into recurrence-snv
…A-analysis into recurrence-snv
…A-analysis into recurrence-snv
…A-analysis into recurrence-snv
Co-authored-by: Jo Lynne Rokita <jharenza@gmail.com>
Co-authored-by: Jo Lynne Rokita <jharenza@gmail.com>
Co-authored-by: Jo Lynne Rokita <jharenza@gmail.com>
kgaonkar6
changed the title
Combine snv per caller and filter for hotspots
Part1 #932 Combine snv per caller and filter for hotspots
Feb 22, 2021
This was referenced Feb 22, 2021
kgaonkar6
changed the title
Part1 #932 Combine snv per caller and filter for hotspots
Part 1 #932 Combine snv per caller and filter for hotspots
Feb 24, 2021
kgaonkar6
changed the title
Part 1 #932 Combine snv per caller and filter for hotspots
Part 1 #819 Combine snv per caller and filter to scavenge hotspots
Mar 1, 2021
kgaonkar6
added
the
ready for review
Used to label pull requests that are ready for review
label
Mar 2, 2021
kgaonkar6
removed
the
ready for review
Used to label pull requests that are ready for review
label
Mar 12, 2021
Please close if #954 seems more reasonable for gathering the hotspots. Thanks! |
Closing in favor of #956 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/implementation Section
In general the question in #819 is to check for hotspots in our data that overlap MSKCC cancer database or other known hotspot sites which could have been missed in consensus calls in
snv-callers
module because the call is found in 1 or 2 out of the 4 callers because of caller limitation.In this PR I'm using strelka2,mutect2,vardict and lancet calls and gather calls that overlap MSKCC hotspots and known TERT promoter mutations.
What scientific question is your analysis addressing?
Gather calls from each callers and filter for
Amino_Acid_Position
which are hotspots per gene or have overlap with the genomic region.What was your approach?
Sql database of all the callers is created using 01-setup_db.py from snv-callers by @jashapiro and @cansavvy.
01-combine-snv.Rmd filters and combines calls from all callers with the below filtering criteria:
Filtering for hotspot overlapping mutations
AND
AND
Amino_Acid_position
in MSKCC cancer hotspot databaseOR
What GitHub issue does your pull request address?
#819
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Which areas should receive a particularly close look?
I checked the paper for a source code : it's in here https://github.com/taylor-lab/hotspots and they also get Amino_Acid_Position that I use to check over from maf column
Protein_position
https://github.com/taylor-lab/hotspots/blob/733c727bd4b9f7c1a7f4508b9a467b2f31cacf33/funcs.R#L602 so should be consistent. My only concern is that only 2 Indels are captured as overlapping MSKCC does that sound OK?Is there anything that you want to discuss further?
Do we think the Amino_Acid_Position + Hugo_Symbol matching between over data and MSKCC database is sufficient ( since it seems in most cases of subtyping/hotspot are actually amino acid site only) or should I do a liftover from hg19 to hg38 for genomic region overlap?.
Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?
Yes
Results
What types of results are included (e.g., table, figure)?
RDS
What is your summary of the results?
1955 calls in hotspot overlap combined maf RDS per tumor sample per caller (593 unique sites)
Reproducibility Checklist
Documentation Checklist
README
and it is up to date.analyses/README.md
and the entry is up to date.