This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jashapiro
reviewed
Apr 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few edits and a rearrangement, but nothing too major, I don't think.
cgreene
approved these changes
Apr 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that should be less than or less than or equal to. Once that gets fixed, this looks fine to me! 🎉
cgreene
pushed a commit
that referenced
this pull request
Apr 10, 2020
This build is based on 9343a4e. This commit was created by the following Travis CI build and job: https://travis-ci.com/AlexsLemonade/OpenPBTA-manuscript/builds/159787617 https://travis-ci.com/AlexsLemonade/OpenPBTA-manuscript/jobs/318155696 [ci skip] The full commit message that triggered this build is copied below: Merge pull request #93 from AlexsLemonade/cnv_consensus CNV consensus calls methods add
cgreene
pushed a commit
that referenced
this pull request
Apr 10, 2020
This build is based on 9343a4e. This commit was created by the following Travis CI build and job: https://travis-ci.com/AlexsLemonade/OpenPBTA-manuscript/builds/159787617 https://travis-ci.com/AlexsLemonade/OpenPBTA-manuscript/jobs/318155696 [ci skip] The full commit message that triggered this build is copied below: Merge pull request #93 from AlexsLemonade/cnv_consensus CNV consensus calls methods add
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Added a section about how the CNV consensus calls. I based this off of what is in the CNV consensus call README said
Issue
#92
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Which areas should receive a particularly close look?
I am unsure about how offbase my description of these methods are. So this should be reviewed by those who have a better idea of this analysis(@jashapiro and @fingerfen)
Hopefully what I've put down helps get you started.
Is the pull request ready for review?
Yes?
Pull review checklist
Unless otherwise noted above, this PR will be considered ready for review when all four items have been checked.
There are no figures or tables added.