Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

CNV consensus calls methods add #93

Merged
merged 5 commits into from
Apr 10, 2020
Merged

CNV consensus calls methods add #93

merged 5 commits into from
Apr 10, 2020

Conversation

cansavvy
Copy link
Collaborator

@cansavvy cansavvy commented Apr 2, 2020

Purpose

Added a section about how the CNV consensus calls. I based this off of what is in the CNV consensus call README said

Issue

#92

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

I am unsure about how offbase my description of these methods are. So this should be reviewed by those who have a better idea of this analysis(@jashapiro and @fingerfen)
Hopefully what I've put down helps get you started.

Is the pull request ready for review?

Yes?

Pull review checklist

Unless otherwise noted above, this PR will be considered ready for review when all four items have been checked.

There are no figures or tables added.

Copy link
Member

@jashapiro jashapiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few edits and a rearrangement, but nothing too major, I don't think.

content/03.methods.md Outdated Show resolved Hide resolved
content/03.methods.md Outdated Show resolved Hide resolved
content/03.methods.md Outdated Show resolved Hide resolved
content/03.methods.md Outdated Show resolved Hide resolved
content/03.methods.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@cgreene cgreene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that should be less than or less than or equal to. Once that gets fixed, this looks fine to me! 🎉

content/03.methods.md Outdated Show resolved Hide resolved
content/03.methods.md Outdated Show resolved Hide resolved
@jaclyn-taroni jaclyn-taroni merged commit 9343a4e into master Apr 10, 2020
cgreene pushed a commit that referenced this pull request Apr 10, 2020
This build is based on
9343a4e.

This commit was created by the following Travis CI build and job:
https://travis-ci.com/AlexsLemonade/OpenPBTA-manuscript/builds/159787617
https://travis-ci.com/AlexsLemonade/OpenPBTA-manuscript/jobs/318155696

[ci skip]

The full commit message that triggered this build is copied below:

Merge pull request #93 from AlexsLemonade/cnv_consensus

CNV consensus calls methods add
cgreene pushed a commit that referenced this pull request Apr 10, 2020
This build is based on
9343a4e.

This commit was created by the following Travis CI build and job:
https://travis-ci.com/AlexsLemonade/OpenPBTA-manuscript/builds/159787617
https://travis-ci.com/AlexsLemonade/OpenPBTA-manuscript/jobs/318155696

[ci skip]

The full commit message that triggered this build is copied below:

Merge pull request #93 from AlexsLemonade/cnv_consensus

CNV consensus calls methods add
@cgreene cgreene deleted the cnv_consensus branch August 27, 2020 10:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants