Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Anndata merge changes from scpca-nf #88

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

jashapiro
Copy link
Member

Closes #87

This PR incorporates changes made to the merge workflow in scpca-nf up to scpca-nf:v0.8.4 to improve compatibility with scanpy expectations.

This includes renaming the script that reformats Anndata and updating it to change PCA matrices to ndarrays, as well as changing PCA and UMAP matrices to lower case and adding a highly_expressed column.

Note that the --output_pca_tsv option in sce_to_anndata.R is unused in this workflow, but is retained to keep the scripts in sync between workflows as much as possible.

@jashapiro jashapiro changed the title Port merge changes from scpca-nf Port Anndata merge changes from scpca-nf Aug 13, 2024
Copy link
Member

@jaclyn-taroni jaclyn-taroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 part of my review was comparing the scpca-nf and OpenScPCA-nf versions of these scripts locally

@jashapiro jashapiro merged commit 45643b5 into main Aug 13, 2024
2 checks passed
@jashapiro jashapiro deleted the jashapiro/87-anndata-updates branch August 13, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port AnnData format changes from scpca-nf
2 participants