-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TSV-ify the download images #257
Conversation
I'm fine with making this name change, but given that we aren't going to include these docs changes until cell type annotation, anything that's already handed off can stay the way it is. I don't want to manually rename since there's like 100 samples of spatial, but I would be fine with including this in the release of |
Yes, definitely.
I'll make an issue in admin that blocks the release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before I approve this:
- The text in the spatial section should be updated to reflect the new name (https://github.com/AlexsLemonade/scpca-docs/blob/sjspielman/238-tsv-images/docs/download_files.md#spatial-transcriptomics-libraries).
- We need an issue in
scpca-nf
to update the filename for the spatial summary and have that issue block the release. - And then a comment on https://github.com/AlexsLemonade/ScPCA-admin/issues/730 about re-running SCPCP000006 prior to hand-off.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, although I don't think changing the file name of the spatial report to have -
instead of _
means it should be in the changelog, but I think that's a question for @dvenprasad.
Stay tuned! |
Ok, it's a no, so I'll revert that commit! |
Closes #238
This PR updates all current download images (not including merged) to reflect that all our metadata files are
.tsv
, not.csv
.There is one additional change here - the spaceranger report along the way got renamed with a
-
; it waslibrary_spaceranger_summary.html
, nowlibrary_spaceranger-summary.html
. I didn't notice this in #238, but saw it here when I filed the PR. I think it's a good move with other naming changes. The other consequences of this are we have to update the name inscpca-nf
(quick fix), and we'd also have to update the file names in the Portal (I guess we can manually rename in prod and include in handoff). Or, we can revert the image back to an_
.Since the reports include the cell type reports, we should only release these updated images with the cell type release, not anndata. So, I'll cherry pick into the cell type release PR once this goes into
development
. Also, I would note in that CHANGELOG that the spatial summary report name has been tweaked.