Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that all column names are "barcode" #668

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

allyhawkins
Copy link
Member

In running through a multiplexed library to completion, there was a lingering error in add_celltypes_to_sce.R where we were checking that the column names were equal to barcode. That works when we only have one column, but when we have multiple, it checks each column name against barcode and returns a vector. R doesn't like that there are multiple TRUE/FALSE values as a vector, so I added the all statement here. If the only column names are barcode then we assign cells to Not run, otherwise we proceed with adding in celltypes.

Note that I did run this and everything ran to completion. I think we are good to do another release with these new bug fixes?

Copy link
Member

@jashapiro jashapiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Not sure about the release question... we aren't waiting for the merging, right?

@allyhawkins
Copy link
Member Author

Not sure about the release question... we aren't waiting for the merging, right?

No, that's going to have to be in a separate release. We need to do a release with the bug fixes for cell typing so that we can get another run of projects going.

@allyhawkins allyhawkins merged commit 8591faa into main Jan 25, 2024
3 checks passed
@allyhawkins allyhawkins deleted the allyhawkins/all-columns-check branch January 25, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants