Check that all column names are "barcode" #668
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In running through a multiplexed library to completion, there was a lingering error in
add_celltypes_to_sce.R
where we were checking that the column names were equal tobarcode
. That works when we only have one column, but when we have multiple, it checks each column name againstbarcode
and returns a vector. R doesn't like that there are multiple TRUE/FALSE values as a vector, so I added theall
statement here. If the only column names arebarcode
then we assign cells toNot run
, otherwise we proceed with adding in celltypes.Note that I did run this and everything ran to completion. I think we are good to do another release with these new bug fixes?