-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce SCE file sizes #712
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 5, 2024
sjspielman
reviewed
Mar 5, 2024
@@ -9,12 +9,12 @@ option_list <- list( | |||
make_option( | |||
opt_str = c("--input_library_ids"), | |||
type = "character", | |||
help = "Comma separated list of library IDs corresponding to the libraries being integrated." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😱
), | ||
make_option( | ||
opt_str = c("--input_sce_files"), | ||
type = "character", | ||
help = "Comma separated list of input sce file paths corresponding to the sces being integrated." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙀
allyhawkins
approved these changes
Mar 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLoses #710
Here I changed all compression of SCE RDS files from gzip to bz2, with the exception of merged files, which I left alone with their current faster but less efficient compression algorithm. (Noting also that the gzip there is already set for low compression, high speed)
I also removed the miQC model from the metadata of the processed data only, and from merged objects. I don't think it will be there in normal processing, but it seemed reasonable to remove in case we want to run the merge script on filtered data at some point.