Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce SCE file sizes #712

Merged
merged 4 commits into from
Mar 5, 2024
Merged

Reduce SCE file sizes #712

merged 4 commits into from
Mar 5, 2024

Conversation

jashapiro
Copy link
Member

CLoses #710

Here I changed all compression of SCE RDS files from gzip to bz2, with the exception of merged files, which I left alone with their current faster but less efficient compression algorithm. (Noting also that the gzip there is already set for low compression, high speed)

I also removed the miQC model from the metadata of the processed data only, and from merged objects. I don't think it will be there in normal processing, but it seemed reasonable to remove in case we want to run the merge script on filtered data at some point.

@@ -9,12 +9,12 @@ option_list <- list(
make_option(
opt_str = c("--input_library_ids"),
type = "character",
help = "Comma separated list of library IDs corresponding to the libraries being integrated."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😱

),
make_option(
opt_str = c("--input_sce_files"),
type = "character",
help = "Comma separated list of input sce file paths corresponding to the sces being integrated."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙀

Copy link
Member

@allyhawkins allyhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jashapiro jashapiro merged commit 4246991 into development Mar 5, 2024
4 checks passed
@jashapiro jashapiro deleted the jashapiro/compress-simplify branch March 5, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants