Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mem_max for all merging and sync changes from main #726

Merged
merged 27 commits into from
Mar 12, 2024

Conversation

allyhawkins
Copy link
Member

In preparation for #654, I'm adjusting the processes in the merging workflow to use mem_max. I think we want to be able to adjust memory for all processes since after the merged object is created, we may need a lot of memory to read them back into R for the report and exporting AnnData objects.

While I was here, I also prepped for #654 by resolving any conflicts between main and development. So there are a few changes that are getting added to keep things in sync.

sjspielman and others added 26 commits February 5, 2024 09:36
…licate-code

Remove duplicated code in cell type module
…g-if-no-processed-cells

Skip any additional processing to processed objects with 0 cells
Co-authored-by: Joshua Shapiro <josh.shapiro@ccdatalab.org>
…m-bump

Add max_mem label for Cell Assign
Copy link
Member

@jashapiro jashapiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@allyhawkins allyhawkins merged commit c8ce02f into development Mar 12, 2024
4 checks passed
@allyhawkins allyhawkins deleted the allyhawkins/mem-max branch March 12, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants