-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use mem_max
for all merging and sync changes from main
#726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…licate-code Remove duplicated code in cell type module
add autofix setting & update
for more information, see https://pre-commit.ci
…g-if-no-processed-cells Skip any additional processing to processed objects with 0 cells
Bump memory for CCDL only
Co-authored-by: Joshua Shapiro <josh.shapiro@ccdatalab.org>
…m-bump Add max_mem label for Cell Assign
jashapiro
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for #654, I'm adjusting the processes in the merging workflow to use
mem_max
. I think we want to be able to adjust memory for all processes since after the merged object is created, we may need a lot of memory to read them back into R for the report and exporting AnnData objects.While I was here, I also prepped for #654 by resolving any conflicts between
main
anddevelopment
. So there are a few changes that are getting added to keep things insync
.