-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip processing if no cells remain after empty droplet filtering #738
Skip processing if no cells remain after empty droplet filtering #738
Conversation
The stub workflow was failing because everything was getting flagged as having no cells since they will all be empty files. I updated this to not consider stub files when checking file size after filtering and processing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, but I made a suggestion that would reduce the number of lines changed in the script by just exiting rather than having an else
block.
I don't think I need to see this again though.
Co-authored-by: Joshua Shapiro <josh.shapiro@ccdatalab.org>
Closes #682
Closes #735
This PR makes some adjustments to the workflow to account for any libraries that have no cells after removing empty droplets. I took a very similar approach to how we handle objects that have 0 cells after removing low-quality cells in the processed object.
filter_sce.R
script, I add a check for the number of columns after removing empty droplets. If that is equal to 0, then an emptyfiltered.rds
is created, otherwise processing proceeds as normal.filtered.rds
file is empty, then any additional steps are skipped. The log will include a note about any libraries that have no cells.While I was here I also accounted for the sample metadata issue and made sure we read in all columns as characters before adding them to the object.
Questions for reviewers: