Account for no cells being assigned to a sample when demultiplexing #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jashapiro
approved these changes
Apr 19, 2024
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, with our test data using
hashedDropsdoesn't assign cells to any of our samples. This prints out an empty list again, which we want to avoid. I checked, and usingHTODemuxonly assigns cells to one sample but not all of them. This leads to a list with just one value while the list of sample IDs is longer. This would mean there is no way to match which cell count goes to which sample.If no cells are assigned, we should set to 0 rather than having an empty list. This PR makes that adjustment by looking for any missing sample IDs and then assigning those to 0.