Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameter for maximum number of libraries to allow when merging #777

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

allyhawkins
Copy link
Member

Closes #776

In processing data for the Portal, we have seen that projects with > 100 libraries do not successfully run through the merge workflow due to what we think is limitations of the packages we use. We don't actually know the number of libraries that cause the problem and it's probably based on number of cells and how big the actual matrices are, but as of right now we do not include any projects with > 100 libraries as merged objects on the Portal.

Because of this, I'm adding a parameter to specify the maximum number of libraries allowed in a merged object and setting the default to 100. If any projects have more than this, then we will print a message to the log files and skip processing that sample.

Copy link
Member

@sjspielman sjspielman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me! I'll note that I also tested this locally (I thought about whether we might want to add this to stub testing, but I don't think that's necessary) -

  • I added a couple lines to the stub run metadata file to give project STUBP08 5 libraries
  • I ran nextflow merge.nf -stub -profile stub --max_merge_libraries 4 --project STUBP08
  • Indeed, I received the message: WARN: Not merging STUBP08 because it contains too many libraries.

nextflow.config Outdated Show resolved Hide resolved
Co-authored-by: Stephanie Spielman <stephanie.spielman@gmail.com>
@allyhawkins
Copy link
Member Author

This all looks good to me! I'll note that I also tested this locally (I thought about whether we might want to add this to stub testing, but I don't think that's necessary) -

  • I added a couple lines to the stub run metadata file to give project STUBP08 5 libraries
  • I ran nextflow merge.nf -stub -profile stub --max_merge_libraries 4 --project STUBP08
  • Indeed, I received the message: WARN: Not merging STUBP08 because it contains too many libraries.

I also don't think this is necessary. We also skip multiplexed libraries in the same way and don't have a stub run for that so I think it's probably good as is.

@allyhawkins allyhawkins merged commit 5363d46 into development Aug 1, 2024
4 checks passed
@allyhawkins allyhawkins deleted the allyhawkins/max-merge branch August 1, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants