Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ng17 migration #10295

Open
wants to merge 37 commits into
base: develop
Choose a base branch
from
Open

Ng17 migration #10295

wants to merge 37 commits into from

Conversation

VitoAlbano
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@VitoAlbano VitoAlbano force-pushed the ng17-migration branch 2 times, most recently from d9c7b15 to ce673e9 Compare October 11, 2024 21:54
@VitoAlbano VitoAlbano force-pushed the ng17-migration branch 3 times, most recently from b2037c1 to cd72f40 Compare November 4, 2024 13:40
@VitoAlbano VitoAlbano force-pushed the ng17-migration branch 3 times, most recently from b988f09 to 24eb40a Compare November 14, 2024 17:17
@ehsan-2019 ehsan-2019 force-pushed the ng17-migration branch 4 times, most recently from 23784bf to e2f0faf Compare November 28, 2024 10:02
@VitoAlbano VitoAlbano force-pushed the ng17-migration branch 3 times, most recently from bac6b18 to e9d7217 Compare December 4, 2024 16:41
@VitoAlbano VitoAlbano force-pushed the ng17-migration branch 6 times, most recently from f506841 to 66c879f Compare December 10, 2024 22:28
VitoAlbano and others added 27 commits December 23, 2024 22:48
@VitoAlbano
[MIGRATION] - Added injectionContext to avoid error NG0203 for unit t…
95175a0 
…ests
@VitoAlbano
[MIGRATION] - Moving mocha to jest
06a094f
@VitoAlbano
[MIGRATION] - Fixing failing migrated tests
0019243
@VitoAlbano
[MIGRATION] - Migrating to Jest - working but some tests fails
f9b5c83
@ehsan-2019 @VitoAlbano
Trying to fix js-api unit tests
13e9c1d
@ehsan-2019 @VitoAlbano
Removing testing lib to sync with develop
02496fe
@ehsan-2019 @VitoAlbano
Fixed two excluded unit tests
4377216
@VitoAlbano
Removed unused project parts
cdca132
@VitoAlbano
Removed unused project parts
bf7abc0
@VitoAlbano
Reduced tserrors on building storybook
2e53634
@VitoAlbano
Fixed sonarqube errors
5891a10
@VitoAlbano
Removing temporarily eslint rule from publishing
375d874
@VitoAlbano
[MIGRATION] - Fixed lint
0f20590
@VitoAlbano
[MIGRATION] - Fixed type
f08280e
@VitoAlbano
[MIGRATION] - Rebased
e7747b9
@VitoAlbano
[MIGRATION] - Readded removed action
7689eac
@VitoAlbano
[MIGRATION] - Checking deps
3f6dda5
@VitoAlbano
[MIGRATION] - updated lock
5031f4b
@AleksanderSklorz @VitoAlbano
[ACS-9052] manage versions close button is too low (#10466)
33dfac5 
* [ci:force] - Fixed lint

* [ACS-9052] Fixed close button in version manager position

* [ACS-9052] Reverted unwanted changes

---------

Co-authored-by: VitoAlbano <vito.albano.123@gmail.com>
@VitoAlbano
[MIGRATION] - fixed storybook builds
a1f0b04
@VitoAlbano
[MIGRATION] - Checking if now eslint is releasable
1299306
@VitoAlbano
[MIGRATION] - Changing the building executor for eslint-rules
19a54f2
@VitoAlbano
Readded rule for peer deps
606989d
@VitoAlbano
Fixed wrong rule
3693b5b
@AleksanderSklorz @VitoAlbano
[ACS-9075] Fixed incorrect buttons labels color (#10489)
401b5c7
@dominikiwanekhyland @VitoAlbano
Update package.json
02a4ffa
@dominikiwanekhyland @VitoAlbano
Fix ACA pipeline
bddca49
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
48 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.5% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eromano eromano eromano approved these changes

@DenysVuika DenysVuika DenysVuika approved these changes

@popovicsandras popovicsandras Awaiting requested review from popovicsandras popovicsandras is a code owner

Assignees
No one assigned
Labels
do not merge 🙅🏻‍♂️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@VitoAlbano @DenysVuika @eromano @alep85 @ehsan-2019 @AleksanderSklorz @dominikiwanekhyland @swapnil-verma-gl