Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement bipartite property graphs and refactor graphviz bipartite graph methods #895

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Implement bipartite property graphs and refactor graphviz bipartite graph methods #895

wants to merge 13 commits into from

Conversation

slwu89
Copy link
Member

@slwu89 slwu89 commented Mar 6, 2024 •
edited
Loading

Address #888

Please note the changes to https://github.com/AlgebraicJulia/Catlab.jl/pull/895/files#diff-77b8985182dac144d246a8e8f0becf17233222f79879274682b78adf2e454ca4 I suspect it was a typo that some small subset of the generic bipartite graph methods have argument type AbstractBipartiteGraph rather than HasBipartiteGraph (a narrower type instead of a wider type), so I changed that.

@slwu89 slwu89 requested a review from epatters March 7, 2024 00:06
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2024

Review Checklist

Does this PR follow the development guidelines? Following is a partial checklist:

Tests

  • New features and bug fixes have unit tests
  • New modules have tests that are ultimately called by the test runner (test/runtests.jl)
  • Existing tests have not been deleted
  • Code coverage >= 90% or reduction justified in PR

Documentation

  • All exported functions, types, and constants have docstrings, written in complete sentences
  • Citations are given for any constructions, algorithms, or code drawn from external sources

Other

  • Style guidelines are followed, including indent width 2
  • Changes breaking backwards compatibility have been approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epatters epatters Awaiting requested review from epatters

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
cleanup enhancement graphics graphs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slwu89 @epatters