Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loosen type in to_graphviz_property_graph #932

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Loosen type in to_graphviz_property_graph #932

merged 1 commit into from
Aug 16, 2024

Conversation

slwu89
Copy link
Member

@slwu89 slwu89 commented Aug 16, 2024

The type in to_graphviz_property_graph is too narrow, the function calls down to the PropertyGraph constructor which is defined for type HasGraph.

@epatters epatters changed the title fix type in to_graphviz_property_graph Loosen type in to_graphviz_property_graph Aug 16, 2024
epatters
epatters approved these changes Aug 16, 2024
View reviewed changes
Copy link
Member

@epatters epatters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sean!

@epatters epatters merged commit d336c7b into AlgebraicJulia:main Aug 16, 2024
8 checks passed
@slwu89 slwu89 deleted the graphtypes-fix branch August 16, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epatters epatters epatters approved these changes

Assignees
No one assigned
Labels
bug graphics graphs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slwu89 @epatters