Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check types at compile-time, not parse-time #109

Closed
lukem12345 opened this issue Mar 23, 2023 · 2 comments
Closed

Check types at compile-time, not parse-time #109

lukem12345 opened this issue Mar 23, 2023 · 2 comments
Assignees

Comments

@lukem12345
Copy link
Member

Currently, we check that the types are a 0-Form, 1-Form, etc., and raise an error if a type is e.g. VectorField when we are parsing.

Since:

  • This restriction is only needed to check that a Decapode will compile correctly.
  • There is no restriction inherent to the Decapode schema that prohibits encoding equations from e.g. the usual vector calculus.

We should move this check to somewhere inside gensim.

@lukem12345 lukem12345 self-assigned this Mar 23, 2023
@lukem12345
Copy link
Member Author

lukem12345 commented Mar 23, 2023

We should revisit this topic when we label Decapodes with the calculus it comes from using types, since there may be value then in detecting such mal-formed types at parse-time. AlgebraicJulia/DiagrammaticEquations.jl#19

For example, if I say that my equations are written in the 1D DEC, then there is value in throwing a parsing error when I try to use a 2-Form.

@lukem12345
Copy link
Member Author

Closed by #117

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant