Move type checking to compile #111
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpfairbanks
reviewed
Mar 24, 2023
| @@ -141,6 +141,7 @@ gensim(d::AbstractNamedDecapode) = gensim(d, | |||
| vcat(collect(infer_state_names(d)), d[incident(d, :Literal, :type), :name])) | |||
|
|
|||
| function gensim(d::AbstractNamedDecapode, input_vars) | |||
| recognize_types(d) | |||
There was a problem hiding this comment.
This looks mutating, should have ! In the name
There was a problem hiding this comment.
This function checks that types are in the set {Form1, ..., Constant, Literal, etc.}.
There is a function called infer_types! which does indeed mutate the types of a Decapode. I'm not completely satisfied with this name recognize_types. Do you have a suggestion?
There was a problem hiding this comment.
If a function calls a mutating function on its argument, then it is mutating too. What is recognize_types adding over infer_types!
jpfairbanks
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #109