Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ComponentArrays.jl #165

Closed
lukem12345 opened this issue Nov 1, 2023 · 2 comments
Closed

Use ComponentArrays.jl #165

lukem12345 opened this issue Nov 1, 2023 · 2 comments
Assignees
@lukem12345
Labels
enhancement New feature or request

Comments

@lukem12345
Copy link
Member

We should use ComponentArrays.jl instead of MultiScaleArrays.jl.

This should just require swapping around the PhysicsState struct, and changing calls to findnode.
@lukem12345 lukem12345 added the enhancement New feature or request label Nov 1, 2023
@lukem12345 lukem12345 self-assigned this Nov 2, 2023
@lukem12345
Copy link
Member Author

Since we do not make use of any of the “MultiScale” features of MultiScaleArrays, and it likely being faster anyway to flatten our state vectors, then it makes sense to drop support entirely for MultiScaleArrays.

@lukem12345
Copy link
Member Author

Closed by #167 . Thanks Chris!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukem12345 lukem12345

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lukem12345