Switch to ComponentArrays #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep life simple man. ComponentArrays keeps a hierarchical abstract structure with an underlying vector, and thus works much better with many operations in terms of performance, but also works with LinearAlgebra in nicer ways than a MultiScaleArray. Given that the size of the state is constant, this is a much simpler thing to use. Also, it's faster. On Bukyko-Sellers: ```julia using BenchmarkTools @Btime solve(prob, Tsit5(), save_everystep=false); # Before: # 1.141 ms (2150 allocations: 60.66 KiB) # After: # 11.917 μs (145 allocations: 12.66 KiB) ```
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #167 +/- ##
==========================================
- Coverage 74.51% 74.42% -0.10%
==========================================
Files 9 9
Lines 1126 1122 -4
==========================================
- Hits 839 835 -4
Misses 287 287
☔ View full report in Codecov by Sentry. |
jpfairbanks
approved these changes
Nov 2, 2023
|
🎉 |
jpfairbanks
approved these changes
Nov 3, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep life simple man. ComponentArrays keeps a hierarchical abstract structure with an underlying vector, and thus works much better with many operations in terms of performance, but also works with LinearAlgebra in nicer ways than a MultiScaleArray. Given that the size of the state is constant, this is a much simpler thing to use.
Also, it's faster. On Bukyko-Sellers: