-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ice Dynamics #123
Merged
Merged
Ice Dynamics #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #123 +/- ##
==========================================
+ Coverage 88.38% 88.40% +0.01%
==========================================
Files 9 9
Lines 999 1009 +10
==========================================
+ Hits 883 892 +9
- Misses 116 117 +1
☔ View full report in Codecov by Sentry. |
jpfairbanks
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces an ice model based on Halfar's "On the Dynamics of Ice Sheets". (1981).
We also update the Budyko-Sellers model to demonstrate composition.
There is also a fix to type inference of summations in this PR.
Equation 2 from Halfar's "On the Dynamics of Ice Sheets". (1981).
Ice Dynamics Diagram Generated From Above Equation
Glacial Flow Auto-Generated From Above Diagram
Ice height is initialized as an upwards parabola centered at (0,0).