Use diagonal hodge in docs overview #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukem12345
added
documentation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #141 +/- ##
=======================================
Coverage 88.70% 88.70%
=======================================
Files 9 9
Lines 1036 1036
=======================================
Hits 919 919
Misses 117 117 ☔ View full report in Codecov by Sentry. |
GeorgeR227
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
overview.mdpreviously used theDiagonalHodge. In the new docs,GeometricHodgewas swapped in its place. This normally should not result in drastically different behavior. However, the way thatperiodic_meshis implemented alongside apoint_mapmeans that calculations insideGeometricHodgewill introduce artifacting where this periodic mesh is stitched together.