-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Boundary Conditions as Collage-Decapodes #151
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #151 +/- ##
==========================================
+ Coverage 75.17% 76.13% +0.96%
==========================================
Files 11 10 -1
Lines 1172 1207 +35
==========================================
+ Hits 881 919 +38
+ Misses 291 288 -3 ☔ View full report in Codecov by Sentry. |
The collate function as of the most recent commit is correct for boundary masks applied to state variables or tangent variables. |
I have marked this PR as "ready for review" since the source code and tests are complete (up to passing the review stage). So, the code and tests themselves are ready to review as I concurrently write the docs and example scripts to accompany this new feature set. |
Sadly this didn't get merged before the component-arraypocalypse. so it needs to be brought up to date (@lukem12345). There are also merge conflicts now. |
Disadvantage to not using |
What are your thoughts on the docs page. Good enough for merge? The accompanying demo is the so-called |
DiagrammaticEquations.jl has the collage source and test code now, so this PR is closed by that repo! |
Closes #144
With @p-stokes , this branch will encode boundary conditions and initial conditions as morphisms between Decapode diagrams.
One Decapode represents the physical equations, and the other represents values to set along boundaries.
TODO:
Pass masking test where a Var in the discrete Decapode is computed from other vars in that Decapode.