Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two space indentation #209

Merged
merged 2 commits into from
Mar 1, 2024
Merged

Two space indentation #209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd207fe
format: indent with two spaces pls
olynch Feb 29, 2024
f33f54b
Merge branch 'main' into two-space-indentation
jpfairbanks Mar 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/coordinates.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,19 +7,19 @@ using CombinatorialSpaces.MeshInterop
a point in cartesian coordinates, intended as a wrapper around Point3 from GeometryBasics.
"""
struct CartesianPoint{T}
p::T
p::T
end

r(p::CartesianPoint) = hypot(p.p...)
theta(p::CartesianPoint) = atan(sqrt(p.p[1]^2 + p.p[2]^2)/p.p[3])
phi(p::CartesianPoint) = atan(p.p[2]/p.p[1])

""" SpherePoint{T}(p)

a point in spherical coordinates, intended as a wrapper around Point3 from GeometryBasics.
"""
struct SpherePoint{T}
p::T
p::T
end

r(p::SpherePoint) = p.p[1]
Expand Down Expand Up @@ -47,15 +47,15 @@ If the base point is in spherical coordinates, this is the identity,
if the base point is in cartesian coordinates, it returns the tangent vector in cartesian coordinates.
"""
function (tb::TangentBasis)(w)
tb(w[1], w[2])
tb(w[1], w[2])
end

function (tb::TangentBasis{P})(w) where {P <: SpherePoint}
return w
return w
end

function (tb::TangentBasis)(w1,w2)
w1p = w1*θhat(tb)
w2p = w2*ϕhat(tb)
return w1p + w2p
w1p = w1*θhat(tb)
w2p = w2*ϕhat(tb)
return w1p + w2p
end
Loading
Loading