Smaller compiler refactoring #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpfairbanks
reviewed
Jun 10, 2024
src/simulation.jl
Outdated
| throw(AmbiguousNameException(s, found_names_idxs)) | ||
| end | ||
|
|
||
| if is_all_literals | ||
| push!(stmts.args, :($s = $(parse(stateeltype, String(s))))) |
There was a problem hiding this comment.
It looks like this is still creating assignments for literals.
There was a problem hiding this comment.
Yeah that's right. I just forgot to move the comment up with it.
|
I think GitHub actions is having some trouble but I'll rerun the actions later and then this should be ready for review. |
Test Summary: | Pass Total Time
CUDA | 9 9 4m01.0s
Testing Decapodes tests passed
shell> git log -1
commit 3ad6cd0e6a12b775d562d9b91d92f1e95b23cd3a (HEAD -> gr/prep-compiler, origin/gr/prep-compiler)
Author: GeorgeR227 <78235421+GeorgeR227@users.noreply.github.com>
Date: Tue Jun 11 16:41:39 2024 -0400
Final cleanup |
This backend will be inherited by user defined code targets, allowing for users to only replaces the hooks they want.
Also more exceptions
Issue comes from the fact that composing decapodes with the same literals copies them separately, so they're not unique in name.
This reverts commit 7a232c8.
Also add better typing to CUDAExt
This gets rid of default values in lower level compiling functions to reduce the possibility of errors caused by not passing in all arguments.
More tests!
GeorgeR227
force-pushed
the
gr/prep-compiler
branch
from
3ad6cd0 to
92d2cff
Compare
lukem12345
reviewed
Jun 13, 2024
lukem12345
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to clean up the compiler to ready it for larger refactors to come.