Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use upstreamed averaging operator #243

Merged
merged 3 commits into from
Jun 13, 2024
Merged

Use upstreamed averaging operator #243

merged 3 commits into from
Jun 13, 2024

Conversation

lukem12345
Copy link
Member

Close #242

@lukem12345 lukem12345 self-assigned this Jun 12, 2024
@lukem12345 lukem12345 changed the title Support averaging operator in backend Use upstreamed averaging operator Jun 12, 2024
@lukem12345 lukem12345 requested a review from GeorgeR227 June 12, 2024 18:26
@lukem12345
Copy link
Member Author

PR 39 to DiagrammaticEquations.jl added ASCII bindings for the averaging operator, and that is now documented here.

@lukem12345 lukem12345 marked this pull request as ready for review June 12, 2024 18:40

function dec_cu_avg₀₁(sd::HasDeltaSet)
# TODO: Cast this in the CombinatorialSpaces CUDA extension directly.
avg_mat = CuSparseMatrixCSC(avg₀₁_mat(sd))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test this on CUDA to make sure types are stable.

@GeorgeR227
Copy link
Collaborator

@lukem12345 Also run the tests with CUDA and post if they pass.

@lukem12345 lukem12345 merged commit a09020c into main Jun 13, 2024
7 of 8 checks passed
@lukem12345 lukem12345 deleted the llm/avg branch June 13, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use upstreamed averaging operator
2 participants