Skip to content

Commit

Permalink
Fix an idiotic bug with npx(1)
Browse files Browse the repository at this point in the history
Backticks aren't escaped in npx(1)'s positional arguments like they used
to, and they're also passed to sh(1) as double-quoted strings (which the
FUCK would you not use single-quotes??!). Because the `--header` comment
contained "run `make types` to update", NPM was essentially fork-bombing
its process.

References: npm/run-script#14
  • Loading branch information
Alhadis committed May 25, 2021
1 parent 9e22bab commit 275bf78
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ all: install lint types test
# Generate TypeScript declarations from JSDoc
types: index.d.ts
index.d.ts: index.mjs lib/*.mjs
npx jg typewrite \
"`npx jg -p typewrite`" \
--exclude BlendModes \
--declare const BlendModes '{[key: string]: (...args: number[]) => number};' \
--header '// Generated file; run `make types` to update.' \
Expand Down

0 comments on commit 275bf78

Please sign in to comment.