Encode URL param for external player #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xhofe
approved these changes
May 2, 2024
gmugu
pushed a commit
to gmugu/alist-web
that referenced
this pull request
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The URL passed as query parameter for IINA will be url-encoded. This will fix
Cannot open file or stream!showing when URL contains special characters (e.g./[foo] bar.mkv) for IINA.This is somehow related to a bug in IINA fix: avoid double percent-encode for url scheme, but I think it is better to do url-encoding in alist to support IINA until this bug has been resolved.
Additionally, if the filename contains a
%, then it is expected to be encoded per URI standard. In this case, it is not an IINA bug.