fix: don't push docker on pr due to security

AlistGo · Feb 23, 2024 · 742335f · 742335f
1 parent f1979a8
commit 742335f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 26 deletions.
diff --git a/.github/workflows/build_docker.yml b/.github/workflows/build_docker.yml
@@ -46,6 +46,7 @@ jobs:
         uses: docker/setup-buildx-action@v3
 
       - name: Login to DockerHub
+        if: github.event_name == 'push'
         uses: docker/login-action@v3
         with:
           username: xhofe
@@ -57,7 +58,7 @@ jobs:
         with:
           context: .
           file: Dockerfile.ci
-          push: true
+          push: ${{ github.event_name == 'push' }}
           tags: ${{ steps.meta.outputs.tags }}
           labels: ${{ steps.meta.outputs.labels }}
           platforms: linux/amd64,linux/arm64,linux/arm/v7,linux/386,linux/arm/v6,linux/s390x
@@ -67,7 +68,7 @@ jobs:
         uses: docker/build-push-action@v5
         with:
           file: Dockerfile.ffmpeg
-          push: true
+          push: ${{ github.event_name == 'push' }}
           tags: ${{ steps.meta-ffmpeg.outputs.tags }}
           labels: ${{ steps.meta-ffmpeg.outputs.labels }}
           platforms: linux/amd64,linux/arm64,linux/arm/v7,linux/386,linux/arm/v6,linux/s390x

diff --git a/.github/workflows/del-pr-docker.yml b/.github/workflows/del-pr-docker.yml