-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(123pan): optimize rate limiting #6859
Conversation
- eliminating fixed 200 ms delay in getFiles to prevent thread starvation - allowing cancellation via context to mitigate potential DoS attacks by immediately cancelling excessive requests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have encountered performance issues these days. After applying these changes, it works well.
This reverts commit AlistGo#6859, which introduced performance enhancements in AlistGo#6859. Unfortunately, these changes led to unintended consequences resulting in account bans. The revert is necessary until a more thorough review and testing can be conducted to ensure no negative impacts on account status.
@xrgzs 经过对代码逻辑的确认,接口限流间隔依然是之前 123 云盘官方提交的 700 ms,下面是实际调试截图,可以看到是按 700 ms 间隔请求的: 之前在测试时一天内多次触发 123 云盘风控,但账号能正常登录,只是 IP 被封禁,且光猫重新拨号后能正常使用: 猜测账号封禁原因可能与你截图里显示的异地登录有关? |
异地登录倒是没有,我这边的所有登录设备都是处于同一IP的。之前用老版本没有出现问题,更换新版以后跑两天就出事了,现在回到老版本,再测试几天。 |
- eliminating fixed 200 ms delay in getFiles to prevent thread starvation - allowing cancellation via context to mitigate potential DoS attacks by immediately cancelling excessive requests
perf(123pan): optimize rate limiting
Under a concurrency of 5 requests, performance improvement is as follows:
before
after
Benchmark Commands