fix(search): BuildIndex concurrency error #7035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xhofe
approved these changes
Aug 21, 2024
Three-taile-dragon
pushed a commit
to loognsss/blist
that referenced
this pull request
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check Running and store true is not an atomic operation, Quit and Running will be wrong variable when StopIndex and UpdateIndex called from http api or index auto_update enabled, leading to goroutine leak, alist log is full of index log:
I removed Running variable, use Quit pointer to check BuildIndex is running, intruducing local running variable to notify WalkDir stop running, make sure only one goroutine is running BuildIndex.