Fix os.create failure, while the name of downloaded file is empty in offline_download #7041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! Please check out our contributing guidelines. |
xhofe
approved these changes
Aug 21, 2024
|
Congrats on merging your first pull request! We here at behavior bot are proud of you! |
Three-taile-dragon
pushed a commit
to loognsss/blist
that referenced
this pull request
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Offline download with the SimpleHttp tool parses the filename from the requesting URL. However, if the path in the URL is empty, the filename is also empty (which is then transformed into ‘.’ by path.Base).
If the filename is empty, TempDir is set to the filename. Alist creates TempDir successfully, but os.Create fails to create the target file.
To resolve this, I assign a default name to the temp file based on the hostname, replacing all dots with underscores. This ensures that TempDir and the filename are never equal.