feat: support os/arch param #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhyasdf
approved these changes
Jan 10, 2024
|
Thanks for your contribution! Seems it's forgotten during last refactoring :D. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Describe what this PR does / why we need it
Does this pull request fix one issue?
Fixes #143
Describe how you did it
Set
osFilterListandarchFilterListwith external parameters.Describe how to verify it
As follow:
s1: download and start harbor private by https://goharbor.io/docs/2.4.0/install-config/download-installer/
s2: edit
auth.ymlandimages.ymlfiles3: execute command
./image-syncer --arch=amd64 --arch=arm64 --os=linux --proc=4 --auth=./auth.yaml --images=./images.yaml --retries=3s4: login harbor registry and see images arch.
Special notes for reviews