bugfix: update label compatibility with alidocker #1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Wan <zirenwan@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1228 +/- ##
==========================================
- Coverage 15.44% 15.43% -0.01%
==========================================
Files 171 171
Lines 10576 10579 +3
==========================================
Hits 1633 1633
- Misses 8823 8826 +3
Partials 120 120
|
allencloud
reviewed
Apr 26, 2018
| @@ -2110,10 +2110,10 @@ definitions: | |||
| type: "array" | |||
| items: | |||
| type: "string" | |||
| Labels: | |||
| Label: | |||
There was a problem hiding this comment.
Let us keep this, and update this to Labels in sometime when ok.
|
LGTM |
pouchrobot
added
the
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Wan zirenwan@gmail.com
Ⅰ. Describe what this PR did
fix update compatibility with alidocker
alidocker update container label is
[]stringpouch
UpdateConfig.Labelismap[string]stringⅡ. Does this pull request fix one issue?
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews